Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k8s] Surface docker permission error for sky local up #2913

Conversation

Shrinandan-N
Copy link
Contributor

Fixes #2592.

This pull request updates create_cluster.sh to enhance the handling of Docker permission errors. The revised script captures the output and error messages from docker info. It identifies and distinguishes between 'permission denied' errors and scenarios where Docker is not running, and alerts the user with an error message accordingly.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Created test user without docker permission (not in docker group) and verified that a permission error was reported instead of the standard "Docker is not running" error.
  • Added test user to docker group and ran sky local up to ensure that permission error/docker error did not prevail after docker permissions were granted.

Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @Shrinandan-N! Left a minor comment, otherwise good to go!

sky/utils/kubernetes/create_cluster.sh Outdated Show resolved Hide resolved
@romilbhardwaj romilbhardwaj changed the title fix docker permission error in issue 2592 [k8s] Surface docker permission error for sky local up Dec 29, 2023
@Shrinandan-N
Copy link
Contributor Author

Sounds good @romilbhardwaj, accepted the commit suggestion!

@romilbhardwaj romilbhardwaj merged commit 6c0cbcc into skypilot-org:master Dec 29, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[k8s] sky local up shows Docker is not running while docker is running
2 participants