Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve has files check (fixes #15) #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

markvandenbrink
Copy link

The has files check currently only checks the existence of a files property in the package.json file. But according to the npm docs you can also use a .npmignore file to do so:

You can also provide a .npmignore file in the root of your package or in subdirectories, which will keep files from being included.

This MR adds a condition to check if a .npmignore file is present so it can pass the test without a files property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant