-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut down feed ingress vulnerabilities #230
Conversation
To avoid talking to a real aws service. The endpoint simply returns OK on any request which feed-ingress inteprets to mean no ELB. * Define endpoint for ec2 metadata So we can make our fake-elb return a mock response for the instance metadata * Remove unused feed args This test doesn't use any ELB, so no need for feed to run on hostNetwork or define ports to receive ELB traffic from
To cut down on the attach surface and so reduce the number of vulnerabilities. alpine 3.13 shows we have 0 vulnerablities when run via trivy
This reverts commit 908f7db.
To make it clear which alpine release feed-ingress is based on.
Use trivy to fail the build when either HIGH or CRITICAL vulnerabilities are found.
This commit 908f7db showed how we used |
We've now tested opentracing too and found that it works fine. The path to the jaeger plugin was wrong, so we fixed it in b102ece. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
To cut down on the attack surface
and so reduce the number of vulnerabilities.
The previous debian:strech-slim was showing a lot of vulnerabilities
that have all gone away once switching to alpine (3.13).
Also used trivy to fail the build when either HIGH or CRITICAL
vulnerabilities are found.