perf: use code generation to unroll pattern match per country (SWIFT only) #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skwasjer
force-pushed
the
feature/code_gen_unrolled_swift_pattern_match
branch
from
97ce201 to
d0ee2bf
Compare
skwasjer
changed the title
skwasjer
force-pushed
the
feature/code_gen_unrolled_swift_pattern_match
branch
from
d0ee2bf to
fe18e4f
Compare
…it. Exposing internals to TemporaryT4Assembly no longer works, as the temporary assembly has a new name each run (TemporaryT4Assembly_<guid>).
skwasjer
force-pushed
the
feature/code_gen_unrolled_swift_pattern_match
branch
from
fe18e4f to
a491f31
Compare
skwasjer
force-pushed
the
feature/code_gen_unrolled_swift_pattern_match
branch
from
a491f31 to
eb3ebc6
Compare
|
skwasjer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During validation of an IBAN, of all the
IIbanValidationRules most time is spent in theIsMatchingStructureRulevalidator. To increase performance, we can make use of code generation to generate a customSwiftPatternclass per country in theSwiftRegistryProvider, in which the actual pattern validation is unrolled. This provides a significant performance increase as we no longer have to flow through the general purpose pattern validator, avoiding all the loops and branching.Performance gains varies per .NET runtime and per country pattern, but goes as high as ~75% and at least ~25%.
Note:
WikipediaRegistryProviderhas NOT been updated to receive the same treatment.