Require approval on PR #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skwasjer
force-pushed
the
bugfix/sonar_stage_fails
branch
5 times, most recently
from
c06e589 to
93dd756
Compare
skwasjer
force-pushed
the
bugfix/sonar_stage_fails
branch
from
93dd756 to
5adaa3b
Compare
skwasjer
force-pushed
the
bugfix/sonar_stage_fails
branch
from
5adaa3b to
bfc213c
Compare
…e!!: This requires 'external' deployment environment to have reviewer approval protection rule in repo settings, otherwise, we run the risk of exposing repo secrets to outside PR's.
skwasjer
force-pushed
the
bugfix/sonar_stage_fails
branch
from
bfc213c to
e246c74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures we run SonarCloud analysis in context of PR, while having access to repo secrets. However, we must protect from outside PR's 'stealing' our secrets. This problem is solved by requiring external contribs/PR's to be manually approved before this workflow can run, by adding a minimum of 1 reviewer to environment protection rules on env 'external'.
This mechanism is described in this blog:
https://iterative.ai/blog/testing-external-contributions-using-github-actions-secrets