Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update cron-utils dependency #4

Closed
bgooren opened this issue Dec 18, 2018 · 6 comments
Closed

Please update cron-utils dependency #4

bgooren opened this issue Dec 18, 2018 · 6 comments

Comments

@bgooren
Copy link

bgooren commented Dec 18, 2018

Hi!

We're getting a stack trace logged when we add scheduled methods which have comma-separated fields (e.g. "0 0,30 * ? * *").

This was fixed in cron-utils 5.0.5 (see jmrozanec/cron-utils#125).

Can you please update the cron-utils dependency? The 5.0.0 dependency is from august 2016 in any case, which is quite old. They are at version 8.0.0 already.

skuzzle added a commit that referenced this issue Dec 19, 2018
@skuzzle
Copy link
Owner

skuzzle commented Dec 19, 2018

That sounds reasonable. Would you mind testing a current snapshot build in your application? I've just deployed the latest build with upgraded cron-utils dependency as 1.2.1-SNAPSHOT

@bgooren
Copy link
Author

bgooren commented Dec 19, 2018 via email

@bgooren
Copy link
Author

bgooren commented Dec 20, 2018

1.2.1-SNAPSHOT works fine for me 👍

Please note it fixes another bug we encountered: cron-utils 5.0.0 contains a bug where executions on the last day of the month are skipped:
jmrozanec/cron-utils#117

When do you expect to make a new release? Ideally we have one before the end of the month so we don't run into the cron-utils issue mentioned above.

Thanks!

@skuzzle
Copy link
Owner

skuzzle commented Dec 20, 2018 via email

@bgooren
Copy link
Author

bgooren commented Dec 20, 2018

Much appreciated 👍

@skuzzle
Copy link
Owner

skuzzle commented Dec 20, 2018

Released as 1.2.1

@skuzzle skuzzle closed this as completed Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants