Updated documentation and output on some scripts to be more explicit #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
more explicit. 1. Made it clear date in RiseSet.pm is in UTC 2. Updated documentation on --timezone and --place in three scripts 3. added dates to output in the three scripts to remove ambiguity and make them easier to understand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make them easier to understand
General comment: The example scripts are great. I noticed there are some differences when using these scripts as to which dates/events are being referenced. For example, in riseset.pl the date seems to refer to the "set" time, whereas in moon_almanac.pl the date seems to refer to the "rise" time. If you check the output from my branch on these scripts you'll see what I mean. I didn't change any of the date math -- I just changed documentation and added dates to output, but you might consider standardizing that aspect for these example scripts.