Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for criterion being set to train/valid #643

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Add tests for criterion being set to train/valid #643

merged 1 commit into from
Jun 2, 2020

Conversation

BenjaminBossan
Copy link
Collaborator

As discussed in #621.

Also: Add entry to CHANGES.md

ping @YannDubs

Add tests for criterion being set to train/valid
0ddd8be 
As discussed in #621.

Also: Add entry to CHANGES.md
@BenjaminBossan BenjaminBossan self-assigned this May 29, 2020
thomasjpfan
thomasjpfan approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenjaminBossan
Copy link
Collaborator Author

Thanks for reviewing

@BenjaminBossan BenjaminBossan merged commit cbab769 into master Jun 2, 2020
@BenjaminBossan BenjaminBossan deleted the feature/add-tests-for-criterion-train-valid branch June 2, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@ottonemo ottonemo Awaiting requested review from ottonemo

Assignees

@BenjaminBossan BenjaminBossan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenjaminBossan @thomasjpfan