Make to_tensor work correctly with PackedSequence #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, add a bunch of tests for to_tensor. Partly addresses #325.
githubnemo
reviewed
Sep 9, 2018
skorch/tests/test_utils.py
Outdated
| (PackedSequence(x, y), PackedSequence(x, y)), | ||
| ]) | ||
| def test_tensor_conversion(self, to_tensor, X, expected): | ||
| result = to_tensor(X, 'cpu') |
There was a problem hiding this comment.
it might be worthwhile to make this an optional GPU test as well (if available), e.g.
result = to_tensor(X, 'cpu')
# ... asserts ...
if not torch.cuda.is_available():
return
result = to_tensor(X, 'cuda')
# ... asserts ...* Use correct test for PackedSequence. * Add tests for device='cuda'
|
@githubnemo Could you pls review again? |
githubnemo
reviewed
Sep 10, 2018
| pack_padded_sequence(x, y).to('cuda') | ||
| ), | ||
| ]: | ||
| yield X, expected, device |
There was a problem hiding this comment.
can't you avoid code duplication by re-using the parameters? something like
devices = ['cpu']
if torch.cuda.is_available():
devices.append('cuda')
for dev in devices:
for p in params:
yield (p[0], p[1].to(dev), dev)There was a problem hiding this comment.
This unfortunately doesn't work because some of the parameters don't support .to(dev) (list, tuple, dict).
I pondered quite a bit about this parameter thing but finally settled on something that is a little bit repetitive but I hope at least easy to understand.
githubnemo
approved these changes
Sep 10, 2018
spott
pushed a commit
to spott/skorch
that referenced
this pull request
Oct 12, 2018
* Fix a bug that prevented to_tensor from working correctly with PackedSequence * Add a bunch of unit tests for to_tensor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add a bunch of tests for to_tensor.
Partly addresses #325.