address review: improve message in loghelper()

skirpichev · Jan 23, 2025 · 8d28fd8 · 8d28fd8
1 parent 169815d
commit 8d28fd8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Lib/test/test_math.py b/Lib/test/test_math.py
@@ -2533,7 +2533,7 @@ def test_exception_messages(self):
             math.log(x)
         x = -123
         with self.assertRaisesRegex(ValueError,
-                                    f"expected a positive input"):
+                                    f"expected a positive input, got {x}"):
             math.log(x)
         with self.assertRaisesRegex(ValueError,
                                     f"expected a float or nonnegative integer, got {x}"):

diff --git a/Modules/mathmodule.c b/Modules/mathmodule.c
@@ -2232,8 +2232,8 @@ loghelper(PyObject* arg, double (*func)(double))
 
         /* Negative or zero inputs give a ValueError. */
         if (!_PyLong_IsPositive((PyLongObject *)arg)) {
-            PyErr_SetString(PyExc_ValueError,
-                            "expected a positive input");
+            PyErr_Format(PyExc_ValueError,
+                         "expected a positive input, got %S", arg);
             return NULL;
         }