Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPUnit file tests #517

Merged
merged 3 commits into from
Mar 25, 2021

Conversation

DeveloperMarius
Copy link
Contributor

Hey,

in this pull I'm creating some file tests.
This is in active development because I can't test some functions local and have to use github actions to test on a server.

~ Marius

@DeveloperMarius
Copy link
Contributor Author

Hey @skipperbent,

what was your plan with the public function testFiles()?
I added public function testFile() (is working and ready for merge).
Do you have any other tests in mind?

~ Marius

@DeveloperMarius DeveloperMarius changed the title testFiles and test file content on server PHPUnit file tests Mar 24, 2021
@skipperbent
Copy link
Owner

It was basically what you've created. You just beat me to it. Nice work!

@skipperbent
Copy link
Owner

Maybe multiple files/array would be nice. I think it can be easily achieved by just using your existing code

@DeveloperMarius
Copy link
Contributor Author

I will work on that tomorrow. I have some ideas^^

@skipperbent
Copy link
Owner

I will work on that tomorrow. I have some ideas^^

Sounds good! You've made some valuable contributions to the project, so don't stress yourself. I'll wait with the merge and look and eye out for changes here.

@skipperbent skipperbent merged commit fdf11bb into skipperbent:v4-development Mar 25, 2021
@DeveloperMarius DeveloperMarius deleted the file-tests branch November 15, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants