Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary block from websocket subtask creator #809

Conversation

technicallyty
Copy link
Contributor

@technicallyty technicallyty commented Oct 31, 2024

changes:

  • using slices.Chunk instead of manually constructing chunked slices
  • removed the block on spinning up subtasks. for some reason, we would select block on an arbitrary timeout period, even though it wouldn't actually do anything. it was just a random block.
  • remove a debug log while im here because its noisy.

i ran this version of connect with through the validator and had no problems.

@technicallyty technicallyty requested a review from a team as a code owner October 31, 2024 01:30
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.37%. Comparing base (7355199) to head (5789618).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #809      +/-   ##
==========================================
- Coverage   57.41%   57.37%   -0.04%     
==========================================
  Files         214      214              
  Lines       14844    14825      -19     
==========================================
- Hits         8522     8506      -16     
+ Misses       5708     5705       -3     
  Partials      614      614              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technicallyty technicallyty merged commit c5b2cfc into main Oct 31, 2024
15 checks passed
@technicallyty technicallyty deleted the tyler/con-1892-kucoin-provider-health-degrades-at-200-250-markets branch October 31, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants