Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

Remove eval (Function) from specials #12

Merged
merged 5 commits into from
May 19, 2016
Merged

Conversation

lann
Copy link
Contributor

@lann lann commented Dec 10, 2015

No description provided.

@skeggse
Copy link
Owner

skeggse commented Dec 10, 2015

Why?

@lann
Copy link
Contributor Author

lann commented Dec 10, 2015

Eval triggers warnings in many execution environments, and is outright forbidden in others (packaged chrome apps).

@skeggse
Copy link
Owner

skeggse commented Dec 10, 2015

Not targeting anything besides Node. Thanks, though.

@skeggse skeggse closed this Dec 10, 2015
@Marsup
Copy link
Contributor

Marsup commented Dec 10, 2015

It can be converted to static code though, why isn't it that way ?

@arb
Copy link

arb commented Dec 10, 2015

Agreed. This should be reopened.

@hueniverse hueniverse reopened this Dec 10, 2015
@lann
Copy link
Contributor Author

lann commented Dec 10, 2015

CI failure is due to lint in an unmodified file:

Linting results:
    /home/travis/build/hapijs/isemail/test/index.js:
        Line 164: one-var - Split 'const' declarations into multiple statements.

@hueniverse
Copy link
Contributor

@lann might as well fix that.

dominics pushed a commit to dominics/joi-browser that referenced this pull request May 7, 2016
@jeffbski
Copy link

Can this be merged now?

It seems like a good change.

@skeggse
Copy link
Owner

skeggse commented May 12, 2016

Would you please squash your commits, @lann?

@skeggse skeggse merged commit 74dd2cb into skeggse:master May 19, 2016
@skeggse
Copy link
Owner

skeggse commented May 19, 2016

TIL there's a built-in squash button. Thanks!

@hueniverse
Copy link
Contributor

@skeggse Make sure to assign yourself and set a milestone and labels.

@ChrisMcKee
Copy link

any idea when 2.2.0 will be going out?

@skeggse
Copy link
Owner

skeggse commented Jun 21, 2016

@ChrisMcKee Done. Thanks for reminding me :)

@ChrisMcKee
Copy link

Thanks @skeggse 😃

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants