This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? |
Eval triggers warnings in many execution environments, and is outright forbidden in others (packaged chrome apps). |
Not targeting anything besides Node. Thanks, though. |
It can be converted to static code though, why isn't it that way ? |
Agreed. This should be reopened. |
CI failure is due to lint in an unmodified file:
|
@lann might as well fix that. |
dominics
pushed a commit
to dominics/joi-browser
that referenced
this pull request
May 7, 2016
Can this be merged now? It seems like a good change. |
Would you please squash your commits, @lann? |
TIL there's a built-in squash button. Thanks! |
@skeggse Make sure to assign yourself and set a milestone and labels. |
any idea when 2.2.0 will be going out? |
@ChrisMcKee Done. Thanks for reminding me :) |
Thanks @skeggse 😃 |
Closed
Merged
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.