Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not print configuration file if it is blank. #369

Merged
merged 1 commit into from
Dec 28, 2017
Merged

Do not print configuration file if it is blank. #369

merged 1 commit into from
Dec 28, 2017

Conversation

TimSirmovics
Copy link
Contributor

On v2.34.1, when Settings.ConnectionString is set, line 548 of EF.Reverse.POCO.Core.ttinclude throws a NullReferenceException because Settings.ConfigFilePath is null.

It looks like when InitConnectionString() is called, because Settings.ConnectionString is set it exits early and never calls GetConnectionString() which would normally end up setting Settings.ConfigFilePath.

Added an extra check to make sure Settings.ConfigFilePath is set before printing it.

@sjh37 sjh37 merged commit 98537ff into sjh37:master Dec 28, 2017
@sjh37
Copy link
Owner

sjh37 commented Dec 28, 2017

Thanks Tim

@TimSirmovics TimSirmovics deleted the SettingsConfigFilePathNullReference branch December 29, 2017 01:07
@sjh37
Copy link
Owner

sjh37 commented Jan 10, 2018

Released in v2.35.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimSirmovics @sjh37