Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synonym tests #355

Merged
merged 2 commits into from
Dec 1, 2017
Merged

Synonym tests #355

merged 2 commits into from
Dec 1, 2017

Conversation

TimSirmovics
Copy link
Contributor

@TimSirmovics TimSirmovics commented Dec 1, 2017

In preparation for more development on synonyms I have added a test class to cover current synonym functionality.

I have updated the test database creation scripts to create a new database containing synonyms pointing back to the current test database.

So far the only synonym test is to query a synonym.

@sjh37 sjh37 merged commit 3bd6e69 into sjh37:master Dec 1, 2017
@sjh37
Copy link
Owner

sjh37 commented Dec 1, 2017

Hi Tim. instead of creating new databases, just add your tables to the standard efrpg database.
Thanks for the pull request.

@TimSirmovics
Copy link
Contributor Author

Hi Simon,

The reason for the seperate database is because the SQL for the synonyms needs to specifcally cater for objects which exist in another database, so I want to make sure that this is tested correctly.

Aside from the extra database the synonyms have been created in, there is no need for any more.

@TimSirmovics TimSirmovics deleted the SynonymTests branch December 3, 2017 20:38
@sjh37
Copy link
Owner

sjh37 commented Jan 10, 2018

Released in v2.35.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants