Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WriteConnectionSettingComments() is not controlled with includeConnectionSettingComments in v2.37.0? #447

Closed
yyjdelete opened this issue Jul 19, 2018 · 3 comments
Assignees
Labels

Comments

@yyjdelete
Copy link

See d955e81.
Before this commit, IsAzure(bool includeConnectionSettingComments) use includeConnectionSettingComments to see if it will write Database Edition and the others, but the logic is lost in this commit.

@sjh37
Copy link
Owner

sjh37 commented Jul 19, 2018

The logic got moved into a separate function: WriteConnectionSettingComments()

There are basically 2 separate parts:

Part 1

// The following connection settings were used to generate this file:
// The following connection settings were used to generate this file:
//     Configuration file:     "EntityFramework.Reverse.POCO.Generator\App.config"
//     Connection String Name: "MyDbContext"
//     Connection String:      "Data Source=(local);Initial Catalog=northwind;Integrated Security=True;Application Name=EntityFramework Reverse POCO Generator"
// ------------------------------------------------------------------------------------------------

Part 2

// Database Edition        : Developer Edition (64-bit)
// Database Engine Edition : Enterprise
// Database Version        : 13.0.4001.0

Part 1 is controlled via Settings.IncludeConnectionSettingComments
Part 2 is now always written.

Thinking about it, I think Part 2 should also be controlled via Settings.IncludeConnectionSettingComments

I will make the change.
Thanks for pointing this out.

@sjh37 sjh37 self-assigned this Jul 19, 2018
@sjh37 sjh37 added the bug label Jul 19, 2018
sjh37 added a commit that referenced this issue Jul 19, 2018
…onnectionSettingComments. Thanks to yyjdelete.
@sjh37
Copy link
Owner

sjh37 commented Jul 19, 2018

Fixed, this will be in the next release.

@sjh37 sjh37 closed this as completed Jul 19, 2018
@sjh37
Copy link
Owner

sjh37 commented Jul 19, 2018

Released in v2.37.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants