Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler Warning CS0649 #420

Closed
TimSirmovics opened this issue May 15, 2018 · 4 comments
Closed

Compiler Warning CS0649 #420

TimSirmovics opened this issue May 15, 2018 · 4 comments

Comments

@TimSirmovics
Copy link
Contributor

This is a follow up to the issue raised in #328.

After this change, I get 3 compiler warnings per generated Fake context about CS0649. For example:

FakeContext._changeTracker' is never assigned to, and will always have its default value null FakeContext._configuration' is never assigned to, and will always have its default value null FakeContext._database' is never assigned to, and will always have its default value null

The suggestion by @StevenBonePgh in #328 was to edit InitializePartial() to explicitly set the values to null. Another option is to add a #pragma along with the list of other disabled warnings.

Should we go ahead and implement one of these approaches, or can the problem be resolved in another way?

@TimSirmovics
Copy link
Contributor Author

No response.. Should I just submit a PR with the additional pragma statement?

@sjh37
Copy link
Owner

sjh37 commented May 23, 2018

Sorry I missing this Tim, I was away all last week.
The #pragma would effect all future variables, so I would suggest setting these to null would be the best choice here.
I'll make the modification

@sjh37
Copy link
Owner

sjh37 commented May 23, 2018

Thanks for the prod Tim.

@sjh37 sjh37 closed this as completed May 23, 2018
@sjh37
Copy link
Owner

sjh37 commented Jul 17, 2018

Released in v2.37.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants