Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetSqlDbType missing case numeric #419

Closed
krisnatm opened this issue May 11, 2018 · 2 comments
Closed

GetSqlDbType missing case numeric #419

krisnatm opened this issue May 11, 2018 · 2 comments
Assignees
@sjh37
Labels
bug

Comments

@krisnatm
Copy link

Add numeric type to private static string GetSqlDbType(string sqlType, int scale, int precision)

I believe it should be this:

case "decimal":
case "numeric":
sysType = "Decimal";
break;

Currently sysType is returning as VarChar when numeric is passed as sqlType
@sjh37 sjh37 self-assigned this May 11, 2018
@sjh37 sjh37 added the bug label May 11, 2018
sjh37 added a commit that referenced this issue May 11, 2018
@sjh37
#419 GetSqlDbType missing case numeric. Thanks to krisnatm.
b299cb1
@sjh37
Copy link
Owner

sjh37 commented May 11, 2018

Thanks. This will be in the next release.

@sjh37 sjh37 closed this as completed May 11, 2018
sjh37 added a commit that referenced this issue May 11, 2018
@sjh37
#419 Do same to EF.Core
e094923
@sjh37
Copy link
Owner

sjh37 commented Jul 17, 2018

Released in v2.37.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjh37 sjh37

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sjh37 @krisnatm