Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalization translations into Hebrew, German, Polish and Russian #12683

Merged
merged 23 commits into from
Oct 7, 2024

Conversation

AphroBytes
Copy link
Contributor

@AphroBytes AphroBytes commented Oct 2, 2024

Hebrew, German and Russian translations. Hope this can help.

Multilingual or copywriting? 多语言或者文案?

Please submit directly, we will evaluate.

Dev branch!

Any changes should be submitted to the dev branch.
任何改动,请提交到 dev 分支。
--Edited to add Polish

Hebrew, German and Russian translations.
@TCOTC
Copy link
Contributor

TCOTC commented Oct 3, 2024

Please add English for all history operations, like this:

image

@AphroBytes
Copy link
Contributor Author

That is now done.

@TCOTC
Copy link
Contributor

TCOTC commented Oct 3, 2024

Good. There are still a few codes that need to be modified, please refer to: 59bf2ae (#12562)

@88250
Copy link
Member

88250 commented Oct 3, 2024

Hello, please refer to #12562 to modify other related files, thank you.

@AphroBytes
Copy link
Contributor Author

That's now done, is there any others that need modifying? I didn't see anymore? Thank you

@TCOTC
Copy link
Contributor

TCOTC commented Oct 3, 2024

A few problems with code indentation.

Spaces should be used here:

image

image

fix formatting
fix formatting
@AphroBytes
Copy link
Contributor Author

Apologies, should be ok now?

added Polish
Add Polish language
Add Polish language
Add Polish language
Add Polish language
@AphroBytes AphroBytes changed the title Hebrew, German and Russian translations. Hebrew, German, Polish and Russian translations. Oct 3, 2024
@TCOTC
Copy link
Contributor

TCOTC commented Oct 4, 2024

Spaces are also required here:

image

AphroBytes and others added 2 commits October 4, 2024 09:45
@88250
Copy link
Member

88250 commented Oct 6, 2024

Can you please let me know if this change can be merged?

@88250 88250 added this to the 3.1.9 milestone Oct 6, 2024
@88250 88250 changed the title Hebrew, German, Polish and Russian translations. Internationalization translations into Hebrew, German, Polish and Russian Oct 6, 2024
@AphroBytes
Copy link
Contributor Author

Can you please let me know if this change can be merged?

yes, ready to be merged now. As long as everyone agrees and nothing further needs fixing, which as far as I can tell it does not?

Thanks

@TCOTC
Copy link
Contributor

TCOTC commented Oct 6, 2024

Spaces should be used here:

image

There are no mistakes other than this one.

Fixed spacing
@88250 88250 merged commit f965d6b into siyuan-note:dev Oct 7, 2024
@88250
Copy link
Member

88250 commented Oct 7, 2024

感谢你的贡献,思源有你更精彩!
Thank you for your contribution. SiYuan will be more wonderful with you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants