Add data-id attribute to the button of the block menu
#12525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 29db819.
|
可以 Review 了 |
Vanessa219
reviewed
Sep 21, 2024
| icon: "iconList", | ||
| label: window.siyuan.languages.list, | ||
| accelerator: window.siyuan.config.keymap.editor.insert.list.custom, | ||
| protyle, | ||
| nodeElement, | ||
| id, |
There was a problem hiding this comment.
我感觉是不是因为这里用的是 id: 而不是 id?: ，所以才必须有一行 id, 。我看着没感觉有啥用：
There was a problem hiding this comment.
和图片这个没有关系，这里不明白你为什么要修改。这个 id 以前这样写肯定是有用到的。你直接用这个id就行了，不要去修改它。
There was a problem hiding this comment.
turnsOneInto、turnsIntoOne、turnsInto 我搞不懂，改回去了。
不知道该怎么给子菜单添加 data-id
Vanessa219
reviewed
Sep 21, 2024
| const breadcrumb = nodeElement.getAttribute("breadcrumb"); | ||
| window.siyuan.menus.menu.append(new MenuItem({ | ||
| id: "assetSubMenu", |
There was a problem hiding this comment.
我没搞明白这里的 assetSubMenu 起什么作用。
我看代码感觉好像是用来显示子菜单之后聚焦到输入框，但我实际在思源右键弹出块的菜单之后并没有显示子菜单：
siyuan/app/src/protyle/hint/index.ts
Lines 828 to 831 in 3ba4eb7
There was a problem hiding this comment.
但必须要有唯一 id 的话我不知道怎么搞，恢复成 assetSubMenu 的话就没法用 CSS 单独选择了。
你有推荐的方案吗？
Vanessa219
reviewed
Sep 21, 2024
88250
changed the title
data-id attribute to the button of the block menu
This was referenced Sep 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
给块标菜单的 button 添加 data-id 属性 #12518
菜单太多了，我已经眼花了...
我自己感觉好像没问题，但不能保证每个添加 id 的地方都是对的，以后有问题的话再改。