Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to highlight.js v11.11.1 #12357

Closed
TCOTC opened this issue Aug 28, 2024 · 20 comments
Closed

Upgrade to highlight.js v11.11.1 #12357

TCOTC opened this issue Aug 28, 2024 · 20 comments
Assignees
@Vanessa219
Labels
Development
Milestone
3.1.18

Comments

@TCOTC
Copy link
Contributor

TCOTC commented Aug 28, 2024 •
edited
Loading

代码块的语言是 css 的时候会这样：

default.webm

版本：v3.1.4
@Vanessa219
Copy link
Member

这个看上去是 highlight.js 的问题

QQ_1724903015488

@88250
Copy link
Member

88250 commented Aug 29, 2024

可能 CSS 语法高亮就这样吧 😂

@88250 88250 closed this as completed Aug 29, 2024
@Vanessa219
Copy link
Member

highlightjs/highlight.js#4101

@TCOTC
Copy link
Contributor Author

TCOTC commented Aug 29, 2024

补充一下我遇到问题的场景：

default.webm

@Vanessa219
Copy link
Member

这个只能让 highlight.js 跟进了

@TCOTC
Copy link
Contributor Author

TCOTC commented Dec 14, 2024

highlight.js 那边解决了的话这边要什么时候才能更新？

@Vanessa219
Copy link
Member

随时都可以

@TCOTC
Copy link
Contributor Author

TCOTC commented Dec 14, 2024

那边已经 close issue 了，你看看

@Vanessa219
Copy link
Member

等他发版本。

@TCOTC
Copy link
Contributor Author

TCOTC commented Dec 14, 2024

https://github.com/highlightjs/highlight.js/releases/tag/11.11.0

@Vanessa219
Copy link
Member

这个修改已经在里面了？
明早起来弄

@TCOTC
Copy link
Contributor Author

TCOTC commented Dec 14, 2024

在里面了

highlightjs/highlight.js@11.10.0...11.11.0

image

@Vanessa219
Copy link
Member

https://highlightjs.org/download 这个页面还是 11.10.0 。尝试了下根据源码构建，没构建出所有语言的，估计只能等官网更新了。

@Vanessa219 Vanessa219 changed the title 带语法高亮的代码块解析异常 highlight.js 升级到 11.11.0 Dec 15, 2024
@Vanessa219 Vanessa219 added this to the 3.1.16 milestone Dec 15, 2024
@Vanessa219 Vanessa219 reopened this Dec 15, 2024
@88250 88250 changed the title highlight.js 升级到 11.11.0 Upgrade to highlight.js v11.11.0 Dec 15, 2024
@Vanessa219
Copy link
Member

highlightjs/highlightjs.org#22

@88250 88250 modified the milestones: 3.1.16, 3.1.17, backlog Dec 16, 2024
@TCOTC
Copy link
Contributor Author

TCOTC commented Dec 16, 2024 •
edited
Loading

我看到在这些地方有新版的：cdnjs, jsDelivr, unpkg

但是 highlight.min.js 文件都很小只有一百多kb

@TCOTC
Copy link
Contributor Author

TCOTC commented Dec 25, 2024 •
edited
Loading

尝试了下根据源码构建，没构建出所有语言的

@Vanessa219 你用的是 node tools/build.js -t browser 吗？

这个文件大小感觉很接近上个版本的：

image

我直接替换了思源里的 highlight.min.js ，感觉是完整的：

image

唯一的问题是出现了新的问题：

video.webm

@Vanessa219 Vanessa219 changed the title Upgrade to highlight.js v11.11.0 Upgrade to highlight.js v11.111 Dec 26, 2024
@Vanessa219 Vanessa219 changed the title Upgrade to highlight.js v11.111 Upgrade to highlight.js v11.11.1 Dec 26, 2024
@Vanessa219
Copy link
Member

等新版看看吧，11.10.0 有 1.1 M的。

@TCOTC
Copy link
Contributor Author

TCOTC commented Dec 26, 2024

readme 里说网站上下载的会比本地构建大一些

Vanessa219 added a commit that referenced this issue Dec 27, 2024
@Vanessa219
🎨 #12357
16ccda3
Vanessa219 added a commit that referenced this issue Dec 27, 2024
@Vanessa219
🎨 #12357
91a768e
@Vanessa219 Vanessa219 mentioned this issue Dec 27, 2024
Closed
@Vanessa219 Vanessa219 modified the milestones: backlog, 3.1.18 Dec 27, 2024
@TCOTC
Copy link
Contributor Author

TCOTC commented Dec 27, 2024

@Vanessa219 最新的代码提交解决了这个问题，重新构建一下吧

@Vanessa219
Copy link
Member

cd16c7c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vanessa219 Vanessa219

Labels
Development
Projects
None yet
Milestone
3.1.18
Development

No branches or pull requests
3 participants
@88250 @Vanessa219 @TCOTC