Figure.plot/plot3d: Remove parameter "sizes", use "size" instead (Gen…

…ericMappingTools#1809)

Remove the parameter "sizes" in favour of "size" from `Figure.plot`
and `Figure.plot3d`. Deprecation warning was added in v0.4.0
(xref GenericMappingTools#1254, GenericMappingTools#1258), and is to be fully removed in v0.6.0.

pygmt/src/plot.py

@@ -7,7 +7,6 @@
     build_arg_string,
     check_data_input_order,
     data_kind,
-    deprecate_parameter,
     fmt_docstring,
     is_nonstr_iter,
     kwargs_to_strings,
@@ -17,7 +16,6 @@
 
 
 @fmt_docstring
-@deprecate_parameter("sizes", "size", "v0.4.0", remove_version="v0.6.0")
 @check_data_input_order("v0.5.0", remove_version="v0.7.0")
 @use_alias(
     A="straight_line",

pygmt/src/plot3d.py

@@ -7,7 +7,6 @@
     build_arg_string,
     check_data_input_order,
     data_kind,
-    deprecate_parameter,
     fmt_docstring,
     is_nonstr_iter,
     kwargs_to_strings,
@@ -17,7 +16,6 @@
 
 
 @fmt_docstring
-@deprecate_parameter("sizes", "size", "v0.4.0", remove_version="v0.6.0")
 @check_data_input_order("v0.5.0", remove_version="v0.7.0")
 @use_alias(
     A="straight_line",

pygmt/tests/test_plot.py

@@ -452,30 +452,6 @@ def test_plot_datetime():
     return fig
 
 
-@pytest.mark.mpl_image_compare(filename="test_plot_sizes.png")
-def test_plot_deprecate_sizes_to_size(data, region):
-    """
-    Make sure that the old parameter "sizes" is supported and it reports a
-    warning.
-
-    Modified from the test_plot_sizes() test.
-    """
-    fig = Figure()
-    with pytest.warns(expected_warning=FutureWarning) as record:
-        fig.plot(
-            x=data[:, 0],
-            y=data[:, 1],
-            sizes=0.5 * data[:, 2],
-            region=region,
-            projection="X10c",
-            style="cc",
-            color="blue",
-            frame="af",
-        )
-        assert len(record) == 1  # check that only one warning was raised
-    return fig
-
-
 @pytest.mark.mpl_image_compare
 def test_plot_ogrgmt_file_multipoint_default_style():
     """

pygmt/tests/test_plot3d.py

@@ -423,33 +423,6 @@ def test_plot3d_scalar_xyz():
     return fig
 
 
-@pytest.mark.mpl_image_compare(filename="test_plot3d_sizes.png")
-def test_plot3d_deprecate_sizes_to_size(data, region):
-    """
-    Make sure that the old parameter "sizes" is supported and it reports an
-    warning.
-
-    Modified from the test_plot3d_sizes() test.
-    """
-    fig = Figure()
-    with pytest.warns(expected_warning=FutureWarning) as record:
-        fig.plot3d(
-            x=data[:, 0],
-            y=data[:, 1],
-            z=data[:, 2],
-            zscale=5,
-            perspective=[225, 30],
-            sizes=0.5 * data[:, 2],
-            region=region,
-            projection="X10c",
-            style="ui",
-            color="blue",
-            frame=["af", "zaf"],
-        )
-        assert len(record) == 1  # check that only one warning was raised
-    return fig
-
-
 @pytest.mark.mpl_image_compare
 def test_plot3d_ogrgmt_file_multipoint_default_style():
     """