Tests: simplify the PHPCS setup method [1] #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove the `$sniffFiles` parameter which doesn't change between calls to the method anyway and replace it with a class constant and a call to `realpath()` within the function. - Remove the `getSniffFiles()` method which is now no longer needed. - Adjust all calls to the `prepareLocalFileForSniffs()` method to remove the parameter.
|
❤️ I love it. |
|
@sirbrillig Glad you like it ;-) Give me a moment and I'll send part two (and the bug fix PRs). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$sniffFilesparameter which doesn't change between calls to the method anyway and replace it with a class constant and a call torealpath()within the function.getSniffFiles()method which is now no longer needed.prepareLocalFileForSniffs()method to remove the parameter.[1] = yes, more simplifications upcoming, but doing it step by step to allow for easier reviewing of the changes.