-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHPCS: document run parameters in project ruleset #107
PHPCS: document run parameters in project ruleset #107
Conversation
Nice! I didn't know about those options. Thank you. |
Hm... I just got the CI tests to run on contributor PRs and this one fails for php7 with
|
This makes it easier to run the PHPCS command for the project. Includes: * Adding the `Tests` directory to the run - excluding the test case files in `fixtures`. * Cleaning up the result report by using the `basepath` configuration. * Making the run faster by using `parallel` scanning if available,
Hang on, yes, that's my bad, though probably fails on PHP 5 too, but may do so silently. There are two ways to solve this, but I need some input to know which to use:
@sirbrillig Have you got a preference ? I'd recommend option 2. |
80d436e
to
b630271
Compare
I've added a second commit implement option 2 for now. Let me know what you think. |
b630271
to
e753cbc
Compare
Oh, cool. I didn't know you could do that. I like option 2. Thanks! |
Well, as the DealerDirect plugin registers the standard with PHPCS correctly, it's available, so yes, it can be added to the ruleset ;-) |
This makes it easier for contributors to run the PHPCS command for the project.
Includes:
Tests
directory to the run - excluding the test case files infixtures
.basepath
configuration.parallel
scanning if available,