Rename property to allowUnusedParametersBeforeUsed

sirbrillig · Dec 21, 2018 · cf71c42 · cf71c42
1 parent fdc6bb2
commit cf71c42
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php b/VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php
@@ -65,7 +65,7 @@ class VariableAnalysisSniff implements Sniff {
    * Allows unused arguments in a function definition if they are
    * followed by an argument which is used.
    */
-  public $ignoreUnusedArgsBeforeUsed = false;
+  public $allowUnusedParametersBeforeUsed = false;
 
   public function register() {
     return [
@@ -954,7 +954,7 @@ protected function processScopeCloseForVariable($phpcsFile, $varInfo, $scopeInfo
     if ($this->allowUnusedFunctionParameters && $varInfo->scopeType === 'param') {
       return;
     }
-    if ($this->ignoreUnusedArgsBeforeUsed && $varInfo->scopeType === 'param' && $this->areFollowingArgumentsUsed($varInfo, $scopeInfo)) {
+    if ($this->allowUnusedParametersBeforeUsed && $varInfo->scopeType === 'param' && $this->areFollowingArgumentsUsed($varInfo, $scopeInfo)) {
       return;
     }
     if ($varInfo->passByReference && isset($varInfo->firstInitialized)) {

diff --git a/VariableAnalysis/Tests/CodeAnalysis/VariableAnalysisTest.php b/VariableAnalysis/Tests/CodeAnalysis/VariableAnalysisTest.php
@@ -615,7 +615,7 @@ public function testUnusedArgumentsBeforeUsedArgumentsAreIgnoredIfSet() {
     $phpcsFile = $this->prepareLocalFileForSniffs($this->getSniffFiles(), $fixtureFile);
     $phpcsFile->ruleset->setSniffProperty(
       'VariableAnalysis\Sniffs\CodeAnalysis\VariableAnalysisSniff',
-      'ignoreUnusedArgsBeforeUsed',
+      'allowUnusedParametersBeforeUsed',
       'true'
     );
     $phpcsFile->process();