Treat trait properties as definitions (#40)

* Tests: add test for traits with properties * findVariableScope: consider traits also
sirbrillig · Apr 20, 2018 · 57e4231 · 57e4231
1 parent a5a01ba
commit 57e4231
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 1 deletion.
diff --git a/VariableAnalysis/Lib/Helpers.php b/VariableAnalysis/Lib/Helpers.php
@@ -174,7 +174,7 @@ public static function findVariableScope(File $phpcsFile, int $stackPtr) {
         if (($scopeCode === T_FUNCTION) || ($scopeCode === T_CLOSURE)) {
           return $scopePtr;
         }
-        if (($scopeCode === T_CLASS) || ($scopeCode === T_INTERFACE)) {
+        if (in_array($scopeCode, [T_CLASS, T_INTERFACE, T_TRAIT])) {
           $in_class = true;
         }
       }

diff --git a/VariableAnalysis/Tests/CodeAnalysis/VariableAnalysisTest.php b/VariableAnalysis/Tests/CodeAnalysis/VariableAnalysisTest.php
@@ -401,4 +401,16 @@ public function testVariableFunctionCallsCountAsUsage() {
     $expectedErrors = [];
     $this->assertEquals($expectedErrors, $lines);
   }
+
+  public function testTraitsAllowPropertyDefinitions() {
+    $fixtureFile = $this->getFixture('TraitWithPropertiesFixture.php');
+    $phpcsFile = $this->prepareLocalFileForSniffs($this->getSniffFiles(), $fixtureFile);
+    $phpcsFile->process();
+    $lines = $this->getWarningLineNumbersFromFile($phpcsFile);
+    $expectedWarnings = [];
+    $this->assertEquals($expectedWarnings, $lines);
+    $lines = $this->getErrorLineNumbersFromFile($phpcsFile);
+    $expectedErrors = [];
+    $this->assertEquals($expectedErrors, $lines);
+  }
 }
diff --git a/VariableAnalysis/Tests/CodeAnalysis/fixtures/TraitWithPropertiesFixture.php b/VariableAnalysis/Tests/CodeAnalysis/fixtures/TraitWithPropertiesFixture.php
@@ -0,0 +1,11 @@
+<?php
+
+trait Hello {
+    protected $storedHello;
+    public $helloOptions = [];
+    public function sayHelloWorld() {
+        echo "hello world";
+    }
+    abstract public function getWorld();
+}
+