ReactNative compatibility. Allow sinon fakeServer to run in React Native #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve environment either on device or browser debug. ReactNative has xhr support via polyfill. But the check for supporting xhr looked and withEntitlements which is failing in RN. ReactNative does not have window.location so a default assignment and check for undefined window.location was needed.
andpor
changed the title
andpor
changed the title
| @@ -33,6 +33,7 @@ function responseArray(handler) { | |||
| } | |||
|
|
|||
| var wloc = typeof window !== "undefined" ? window.location : {}; | |||
| wloc = typeof wloc !== "undefined" ? wloc : { "host" : "localhost", "protocol" : "http"}; | |||
There was a problem hiding this comment.
Line 35 and 36 could be squashed into one line. You are guaranteed that wloc is defined.
var wloc = typeof window !== "undefined" ? window.location : { "host" : "localhost", "protocol" : "http"};There was a problem hiding this comment.
will do that tomorrow.
|
I think this is fine, but could you just compress the two lines mentioned? I am also going to squash these commits into one, unless you do it yourself, as a final step. |
|
Change is done. Please squash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
Background (Problem in detail) - optional
Solution - optional
How to verify - mandatory