Formatter breaks code

[rssdev10]

JuliaFormatter v0.10.9
julia> versioninfo()
Julia Version 1.5.3
Commit 788b2c77c1 (2020-11-09 13:37 UTC)
Platform Info:
  OS: macOS (x86_64-apple-darwin18.7.0)
  CPU: Intel(R) Core(TM) i7-5557U CPU @ 3.10GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-9.0.1 (ORCJIT, broadwell)
Environment:
  JULIA_EDITOR = "/Applications/Visual Studio Code.app/Contents/Resources/app/bin/code"
  JULIA_NUM_THREADS = 

Following code fragment from the attached file:

p = plot([sin, cos], zeros(0),
          leg = false,
          xlims = (0, 2π),
          ylims = (-1, 1))
anim = Animation()
for x = range(0, stop = 2π, length = 20)
    push!(p, x, Float64[sin(x), cos(x)])
    frame(anim)
end
gif(anim, "out/sin_cos_anim.gif", fps = 15)

is completely broken after applying the formatter from VS Code

p = plot([sin, cos], zeros(0), leg = false, xlims = (0, 2π), ylims = (-1, 1))
anim = Animation()
for x in range(0, stop = 2π, length = 20)
    push!(p, x, Float64[sin(x), cos(x)])
    frame(anim)
end
gif(anim, "out/sin_cos_anim.gif", fps = 15)
    push!(p, x, Float64[sin(x), cos(x)])
    frame(anim)
end
gif(anim, "out/sin_cos_anim.gif", fps = 15)

formatter.txt

[casabre]

I am observing the same within VS Code too. Additionally it takes ages until the formatting has finished in a broken file. Sometimes, the formatting stops with an error message pop-up.

[singularitti]

I am aware of this bug, but I am currently occupied and have no time to fix it. Sorry for now!

[casabre]

I am aware of this bug, but I am currently occupied and have no time to fix it. Sorry for now!

@singularitti I know that it was working. Do you maybe know the version to downgrade for the moment?

[singularitti]

I am aware of this bug, but I am currently occupied and have no time to fix it. Sorry for now!

@singularitti I know that it was working. Do you maybe know the version to downgrade for the moment?

0.2.2. I believe the bug was introduced in #24

[FuZhiyu]

I have a similar issue not sure whether it's caused by the same bug, but let me report it here:

function solve_policies!(𝔸, cmat, lmat, smat, umat, V::AbstractArray{D,2}, param; V̇=nothing)
    @unpack 𝔸, cmat, lmat, smat = cache
    w, r = @unpack S
    for iter in CartesianIndices(V)
        nothing
    end
end


function policyfunction(Vbb::D, Vbf, r, w, b, param)
    if validF & (!validB | (Hcf >= Hcb)) 
        c = cf
    elseif validB & (!validF | (Hcb >= Hcf))# & (Hcb >= Hc0)
        c = cb
    else
        c0, l0, s0, u0, Hc0 = solveclSS(r, w, b, param)
    end
    return c, l, s, u
end

will be

function solve_policies!(
    𝔸,
    cmat,
    lmat,
    smat,
    umat,
    V::AbstractArray{D,2},
    param;
    V̇ = nothing,
)
    @unpack 𝔸, cmat, lmat, smat = cache
    w, r = @unpack S
    for iter in CartesianIndices(V)
        nothing
    end
end


function policyfunction(Vbb::D, Vbf, r, w, b, param)
    if validF & (!validB | (Hcf >= Hcb)) 
        c = cf
    elseif validB & (!validF | (Hcb >= Hcf))# & (Hcb >= Hc0)
        c = cb
    else
end


function policyfunction(Vbb::D, Vbf, r, w, b, param)
    if validF & (!validB | (Hcf >= Hcb))
        c = cf
    elseif validB & (!validF | (Hcb >= Hcf))# & (Hcb >= Hc0)
        c = cb
    else

[rben01]

I cloned locally and tinkered. Seems like it's sufficient to replace the entire format_stdin() function inside the template string in the return statement ofbuildFormatArgs() with just this :

function format_stdin()
    print(format_text(String(read(stdin)); ${options}))      
end

The current version does some funky reading of stdin with readavailable instead of just reading the whole thing in one go with read.

[rben01]

Just submitted a PR that I think fixes this.

#40

[singularitti]

Hey guys, @rssdev10, @casabre, @FuZhiyu, can you try v0.5.1 see if it solves your problems?

[rssdev10]

Thanks, for the code from my primary message it works good.

[FuZhiyu]

It also works for my case now. Thanks!

…

On Wed, Jun 2, 2021 at 2:01 AM rssdev10 ***@***.***> wrote: Thanks, for the code from my primary message it works good. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#28 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACX5M43SQRS34HCMHOPQECLTQXJLVANCNFSM4UKVLOHA> .

[jessymilare]

I was also having this problem and v0.5.1 seems to work fine.