Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge appOptions.data and mount props error #94

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

modai888
Copy link
Contributor

appOptions.data = ()=> ({...appOptions.data, ...props});

When merge appOptions.data and mount props,...appOptions.data is always a function, not an object.

Copy link
Member

@joeldenning joeldenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable. Ideally we'd add tests for this, but since it took a long time for the maintainers to look at this, I will just merge it as-is.

@joeldenning joeldenning merged commit 1af03fd into single-spa:main Jun 29, 2023
@joeldenning
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants