Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pip check in CI #3768

Closed
wants to merge 1 commit into from
Closed

Conversation

jdblischak
Copy link
Collaborator

Issue and/or context: Many of the spatial Python packages that SOMA depends on require Python >= 3.10. pip still installs them into our Python 3.9 CI env, but reports messages like the following:

  Link requires a different Python (3.9.21 not in: '<3.13,>=3.10'): https://files.pythonhosted.org/packages/a5/b5/ea49151c7f846a2f083271c9c0a92c046a0d5b522369e839089d8022e870/spatialdata-0.2.6-py3-none-any.whl (from https://pypi.org/simple/spatialdata/) (requires-python:<3.13,>=3.10)

Changes: Runs pip check to summarize the version incompatibilities

Notes for Reviewer:

@jdblischak jdblischak self-assigned this Mar 12, 2025
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.17%. Comparing base (0b3c43c) to head (a9b101d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3768      +/-   ##
==========================================
+ Coverage   89.15%   89.17%   +0.01%     
==========================================
  Files          54       54              
  Lines        6420     6420              
==========================================
+ Hits         5724     5725       +1     
+ Misses        696      695       -1     
Flag Coverage Δ
python 89.17% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.17% <ø> (+0.01%) ⬆️
libtiledbsoma ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jdblischak
Copy link
Collaborator Author

Well that was reassuring. The pip check passed for the py39 build.

The messages I had seen from pip about Link requires a different Python was simply added by the -v flag to inform why certain versions were skipped. Using the example I copy-pasted above, spatialdata 0.2.6 was not installed because it requires py>=310, and ultimately spatialdata 0.2.5.post0 was installed.

So the build works here in CI because the older fsspec-2023.6.0 was installed, which is incompatible cloud env requirement of fsspec>=2024.10.0,<2025

@jdblischak jdblischak closed this Mar 12, 2025
@jdblischak jdblischak deleted the pip-check branch March 12, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant