Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++/python] Add support for binary column #3745

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

XanthosXanthopoulos
Copy link
Collaborator

@XanthosXanthopoulos XanthosXanthopoulos commented Feb 27, 2025

Issue and/or context: 62236

Changes:

  • Adds a new column type SOMABinaryColumn that can be both an index column and a ordinary attribute.
  • When it is an index column the dimension is internally treated as TILEDB_STRING_ASCII type.
  • When it is an index column extra metadata are required.
  • Values written or returned by such column is casted as std::vector<std::byte>.
  • Enumerations have been optimized like string attributes.

Notes for Reviewer:

@XanthosXanthopoulos XanthosXanthopoulos force-pushed the xan/geometry-dataframe-mq-spatial-read branch from 2142cf2 to 575657d Compare March 2, 2025 15:31
Base automatically changed from xan/geometry-dataframe-mq-spatial-read to main March 2, 2025 23:57
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.18%. Comparing base (4eb9f8b) to head (aa04529).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3745      +/-   ##
==========================================
- Coverage   89.19%   89.18%   -0.02%     
==========================================
  Files          54       54              
  Lines        6416     6426      +10     
==========================================
+ Hits         5723     5731       +8     
- Misses        693      695       +2     
Flag Coverage Δ
python 89.18% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.18% <75.00%> (-0.02%) ⬇️
libtiledbsoma ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@XanthosXanthopoulos XanthosXanthopoulos changed the title [c++/python] Add support for binary column [WIP] [c++/python] Add support for binary column Mar 6, 2025
@XanthosXanthopoulos XanthosXanthopoulos marked this pull request as ready for review March 6, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant