Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Add CMake check for GCC minimum version 13 #3677

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

jp-dark
Copy link
Collaborator

@jp-dark jp-dark commented Feb 5, 2025

Add GCC minimum version check to CMake.

Context: #3154 / [sc-57301]. See also #3673 (review).

@jp-dark jp-dark requested a review from johnkerl February 5, 2025 17:25
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jp-dark !! :)

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.33%. Comparing base (1754fcd) to head (f406379).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3677      +/-   ##
==========================================
+ Coverage   86.29%   86.33%   +0.04%     
==========================================
  Files          55       55              
  Lines        6390     6390              
==========================================
+ Hits         5514     5517       +3     
+ Misses        876      873       -3     
Flag Coverage Δ
python 86.33% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 86.33% <ø> (+0.04%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@jp-dark jp-dark merged commit e1a0ce3 into main Feb 5, 2025
36 checks passed
@jp-dark jp-dark deleted the dark/gcc-13-cmake-check branch February 5, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants