Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Resolve issue with #3611 and pyarrow<17 #3669

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Feb 4, 2025

Issue and/or context: Resolves #3667 as described on #3667; see also #3611.

Changes:

Notes for Reviewer:

[sc-62929]

@johnkerl johnkerl requested a review from nguyenv February 4, 2025 20:26
@johnkerl johnkerl marked this pull request as draft February 4, 2025 20:58
@johnkerl johnkerl removed the request for review from nguyenv February 4, 2025 20:59
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.32%. Comparing base (ce0dc82) to head (38e47be).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3669      +/-   ##
==========================================
+ Coverage   86.27%   86.32%   +0.04%     
==========================================
  Files          55       55              
  Lines        6390     6390              
==========================================
+ Hits         5513     5516       +3     
+ Misses        877      874       -3     
Flag Coverage Δ
python 86.32% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 86.32% <ø> (+0.04%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl force-pushed the kerl/pyarrow-16-compat branch from 071f3bf to 38e47be Compare February 4, 2025 21:26
@johnkerl johnkerl merged commit 3728f13 into main Feb 4, 2025
16 checks passed
@johnkerl johnkerl deleted the kerl/pyarrow-16-compat branch February 4, 2025 22:14
Copy link

github-actions bot commented Feb 4, 2025

The backport to release-1.15 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-1.15 release-1.15
# Navigate to the new working tree
cd .worktrees/backport-release-1.15
# Create a new branch
git switch --create backport-3669-to-release-1.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 3728f1365b3b0e5dbe6766fab873b134578e1ee0
# Push it to GitHub
git push --set-upstream origin backport-3669-to-release-1.15
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-1.15

Then, create a pull request where the base branch is release-1.15 and the compare/head branch is backport-3669-to-release-1.15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[python] Fix test failures for TileDB-SOMA 1.15.6 with pyarrow<17.0
2 participants