[python] Fix enum regression in PR #3647 #3668
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
[sc-62887]
Changes:
When evolving the schema, we need to re-open the array so that on subsequent writes it sees the latest version. Previously this was done in
SOMAArray::write
. Now that we are replacing this withManagedQuery::write
, the reopening step needs to be moved into this method. There should be no performance degradation as are simply moving the same step fromSOMAArray::write
toManagedQuery::write
.Notes for Reviewer:
My original thought was to combine chunks in the Python side to avoid the repeated reopening steps for multiple chunks in the first place, but it sounds like the overhead of creating the copy is worse than reopening.