Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-1.15][c++] Simplify C++ copyright headers #3660

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Feb 3, 2025

Issue and/or context: Manually backport #3619 to the release-1.15 branch given #3619 (comment)

Changes:

Notes for Reviewer:

@johnkerl johnkerl requested a review from jp-dark February 3, 2025 16:15
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.35%. Comparing base (9843f18) to head (c815e1b).
Report is 2 commits behind head on release-1.15.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.15    #3660      +/-   ##
================================================
+ Coverage         86.30%   86.35%   +0.04%     
================================================
  Files                55       55              
  Lines              6381     6381              
================================================
+ Hits               5507     5510       +3     
+ Misses              874      871       -3     
Flag Coverage Δ
python 86.35% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 86.35% <ø> (+0.04%) ⬆️
libtiledbsoma ∅ <ø> (∅)

Copy link
Collaborator

@jp-dark jp-dark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new code should be added in this PR. The following files should be added by a different backport:

  • soma_column.{cc,h}
  • soma_dimension.{cc,h}
  • soma_geometry_column.{cc,h}
  • uni_soma_column.cc

@johnkerl johnkerl force-pushed the backport-3619-to-release-1.15 branch from 5e8a5b4 to b7f8c61 Compare February 3, 2025 17:11
@johnkerl johnkerl force-pushed the backport-3619-to-release-1.15 branch from b7f8c61 to c815e1b Compare February 3, 2025 17:12
@johnkerl johnkerl requested a review from jp-dark February 3, 2025 17:16
@johnkerl
Copy link
Member Author

johnkerl commented Feb 3, 2025

Thanks @jp-dark ! c815e1b

@johnkerl johnkerl merged commit 9a233bf into release-1.15 Feb 3, 2025
26 checks passed
@johnkerl johnkerl deleted the backport-3619-to-release-1.15 branch February 3, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants