[Backport release-1.15] [c++] Fix offsets for nullable columns #3659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
force-pushed
the
backport-3611-to-release-1.15
branch
from
cf98b30 to
1f89d35
Compare
johnkerl
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.15 #3659 +/- ##
================================================
+ Coverage 86.29% 86.35% +0.05%
================================================
Files 55 55
Lines 6377 6381 +4
================================================
+ Hits 5503 5510 +7
+ Misses 874 871 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Thanks @nguyenv ! |
johnkerl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: Manually backport #3611 to the
release-1.15branch given the robofail at #3611 (comment)Changes:
Notes for Reviewer: