Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use core 2.26.0 #2976

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Use core 2.26.0 #2976

merged 2 commits into from
Sep 11, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Sep 11, 2024

[sc-53002]

Uses:

Following our established procedure

The core-arifact URLs were updated as always following our procedure via the one-line, error-proof

./scripts/update-tiledb-version.py 2.26.0

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.99%. Comparing base (515563f) to head (b7b1216).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2976      +/-   ##
==========================================
+ Coverage   89.84%   89.99%   +0.14%     
==========================================
  Files          39       39              
  Lines        4057     4057              
==========================================
+ Hits         3645     3651       +6     
+ Misses        412      406       -6     
Flag Coverage Δ
python 89.99% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.99% <ø> (+0.14%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@@ -343,7 +343,9 @@ def run(self):
"scipy",
# Note: the somacore version is in .pre-commit-config.yaml too
"somacore==1.0.14",
"tiledb~=0.31.0",
# TEMP WHILE WE AWAIT WHEELS
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is temporary while @dudoslav resolves a disk-space issue at PyPI

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW we only use tiledb-py for unit tests now

@johnkerl johnkerl marked this pull request as ready for review September 11, 2024 15:21
@johnkerl
Copy link
Member Author

@nguyenv @eddelbuettel this has a temporary lack-of-pin on tiledb-py -- which is currently ok since we only use typedb-py for unit-testing now -- and there are no storage-format changes in core 2.26.

Let's go ahead & move forward with this for this morning, and I'll update the tiledb-py pin once pypi/support#4744 after which point @dudoslav will be able to publish all PyPI artifacts for tiledb-py 0.32.0.

Copy link
Contributor

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it has to be two-step because of some pypi woes so be it

@johnkerl johnkerl merged commit 687b028 into main Sep 11, 2024
35 checks passed
@johnkerl johnkerl deleted the kerl/use-2.26.0 branch September 11, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants