Tdl 16369 revert back api access change #90
Conversation
tap_zendesk/discover.py
Outdated
| # which does not have read permission | ||
| LOGGER.warning(message) | ||
| else: | ||
| # If any one of stream does not have read permission then raise error. |
There was a problem hiding this comment.
@prijendev The comment here is wrong.
This code snippet depicts that. "If none of the streams are having the 'read' access, then the code will raise an error
tap_zendesk/discover.py
Outdated
| "The account credentials supplied do not have read access for the following stream(s): {}".format(streams_name) | ||
| raise ZendeskForbiddenError(message) | ||
| message = "The account credentials supplied do not have read access for the following stream(s): {}."\ | ||
| "The data for the mentioned streams will not be collected if selected due to a lack of 'read' permission.".format(streams_name) |
There was a problem hiding this comment.
@prijendev Update the message to,
"'The account credentials supplied do not have 'read' access to the following stream(s): {}. The data for these streams would not be collected due to lack of required permission"
| @@ -58,10 +58,18 @@ def discover_streams(client, config): | |||
| streams.append({'stream': stream.name, 'tap_stream_id': stream.name, 'schema': schema, 'metadata': stream.load_metadata()}) | |||
There was a problem hiding this comment.
@prijendev If the stream would not have 'read' access, would we enter the JSON for that stream in the catalog?
There was a problem hiding this comment.
Yes, we would enter the JSON for that stream in catalog
tap_zendesk/discover.py
Outdated
| # which does not have read permission | ||
| LOGGER.warning(message) | ||
| else: | ||
| message = "HTTP-error-code: 403, Error: You are missing the following required scopes: read. "\ | ||
| "The account credentials supplied do not have read access for the following stream(s): {}".format(streams_name) |
There was a problem hiding this comment.
@prijendev Can you also update this message as,
"HTTP-error-code: 403, Error: The account credentials supplied do not have 'read' access to any of streams supported by the tap. Data collection cannot be initiated due to lack of permissions."
Description of change
Manual QA steps
Risks
Rollback steps