Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conversations.custom fields json #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joshuas-meundies
Copy link

Description of change

Updates the conversations.json schema

  • changes the additionalProperties setting
  • adds new properties for various customer interaction details

QA steps

  • automated tests passing

  • manual qa steps passing (list below)

  • Validate the JSON schema changes against sample data to ensure new fields are recognized and old ones still function as expected.

  • Test the tap against the Kustomer API to confirm it properly processes and includes the new fields in the data output.

Risks

  • Potential schema incompatibilities if the new fields do not align with the expected data from the Kustomer API
  • Risk of breaking changes if the alteration to additionalProperties has unintended side effects

Rollback steps

  • revert this branch

@singer-bot
Copy link

Hi @joshuas-meundies, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@singer-bot
Copy link

You did it @joshuas-meundies!

Thank you for signing the Singer Contribution License Agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants