Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly Deselect Unselected Fields #266

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

RushiT0122
Copy link
Contributor

@RushiT0122 RushiT0122 commented Jan 9, 2025

Description of change

TDL-26872: Fixes the extraction of unselected fields for all streams by explicitly deselecting fields in the catalog metadata.

Manual QA steps

Existing connections:

Without making any changes in settings,

  1. App should have new select_fields_by_default checkbox checked by default
  2. Orchestrator should not write new property select_fields_by_default in tap config
  3. Tap extracts newly discovred fields

After unhecking the select_fields_by_default

  1. App should have new select_fields_by_default uncheckbox checked
  2. Tap should read new property equal to `select_fields_by_default==False'
  3. Tap doesn't sync extracts newly discovered fields

New connections:

  1. App should have new select_fields_by_default uncheckbox checked
  2. Tap should read new property equal to `select_fields_by_default==False'
  3. Tap doesn't sync extracts newly discovered fields

Risks

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

@RushiT0122 RushiT0122 marked this pull request as ready for review January 9, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant