Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added propertyMode:value_and_history to request so that properties_ve… #142

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

jacobrobertbaca
Copy link
Contributor

…rsions comes back on response

Description of change

added propertyMode:value_and_history to request so that properties_versions comes back on response

Manual QA steps

  • watched records come through

Risks

  • a little risky, we saw slight differences in list-memberships field values when we added the parameter on the request
    • in one case, a subfield had a slightly different timestamp when we sent the record
    • in another case, a subfield was completely missing
  • ^ we determined there wasn't much we could do about this, hubspot just happened to be returned differently
  • ^ we will have to keep this in mind in case there are data discrepancies

Rollback steps

  • revert this branch

@zachharris1 zachharris1 merged commit c0d9248 into master Feb 16, 2021
@zachharris1 zachharris1 mentioned this pull request Feb 16, 2021
KAllan357 added a commit that referenced this pull request Feb 19, 2021
…rties_versions comes back on response (#142)"

This reverts commit c0d9248.
KAllan357 added a commit that referenced this pull request Feb 19, 2021
…rties_versions comes back on response (#142)" (#144)

This reverts commit c0d9248.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants