Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use includeAllProperties flag for deals #112

Merged
merged 2 commits into from
Feb 21, 2020
Merged

Conversation

nick-mccoy
Copy link
Contributor

Description of change

On 2/12/20, Hubspot's API started returning a lot more additional properties for the deals stream, and appending all of them to requests led to HTTP 414 (url-too-long) errors. Hubspot recommended using the includeAllProperties = True and allPropertiesFetchMode = 'latest_version' params in the request instead.

Manual QA steps

  • Tested on a multiple cloned connections and the 414 error is resolved

Risks

  • Hard to verify that this returns ALL the non-null properties the customer has

Rollback steps

  • revert this branch

@nick-mccoy nick-mccoy merged commit 1554c6f into master Feb 21, 2020
@nick-mccoy nick-mccoy deleted the fix/deals-request-format branch February 21, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants