Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover a review's submitted_at #52

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Recover a review's submitted_at #52

merged 1 commit into from
Jan 23, 2019

Conversation

raphael-riel
Copy link
Contributor

According to https://platform.github.jparrowsec.cnmunity/t/api-v3-pull-request-review-submitted-at/5049/2 there is a property named submitted_at for reviews, which is not (yet) in the documentation.

Please see the API's response:

image

Disclaimer: I edited the file straight on GitHub since I have no way to test my modification. I do use this tap on Stitch tho.

@cmerrick
Copy link
Contributor

Hi @raphael-riel, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link
Contributor

You did it @raphael-riel!

Thank you for signing the Singer Contribution License Agreement.

@raphael-riel
Copy link
Contributor Author

raphael-riel commented Jan 17, 2019

Ok, I got it running with success locally:
image

@luandy64 luandy64 merged commit 6d73653 into singer-io:master Jan 23, 2019
@luandy64
Copy link
Contributor

Thanks for your contribution, @raphael-riel ! 👍

@raphael-riel raphael-riel deleted the patch-1 branch January 23, 2019 18:32
@luandy64
Copy link
Contributor

Just a heads up @raphael-riel , I just deployed this in Stitch too

AJWurts pushed a commit to villagelabsco/tap-github that referenced this pull request Oct 24, 2024
Adding `submitted_at` to the `review` stream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants