Tdl 20302 add query param for pull requests #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savan-chovatiya
approved these changes
Aug 12, 2022
dbshah1212
approved these changes
Aug 12, 2022
sgandhi1311
pushed a commit
that referenced
this pull request
Sep 20, 2022
* TDL-19555 added missing test cases and updated test cases according to code change (#167) * added missing test cases and updated test cases according to code change * removed tags stream as it is not yet added * Updated inturrupted sync assertion * Removed bookmark conversion to utc * updated inerrupted sync assertions * resolved review comments * updated sreams in parent-child test case * resolved review comments * resolved review comments * Updated start_date test * updated date format conversion in test * unskipped incremental child streams from assertion * updated base.py * resolved review comments * resolved review comment * update variable name * resolved review comment and updated print - LOGGER * TDL 19530 update dict based implementation to class based (#168) * added backoff for 5xx error and fixed indexerror when only passed org in config * added missing test cases and updated test cases according to code change * removed tags stream as it is not yet added * Updated inturrupted sync assertion * Removed bookmark conversion to utc * updated inerrupted sync assertions * resolved review comments * updated sreams in parent-child test case * Initial commit. * Removed unnecessary unit test cases. * updated code comments * Resolved pylint errors. * disabled pylint for get_child_records. * Added unittest cases. * Added filter params for commits and comments stream. * Updated unit test cases. * resolved review comments * resolved review comments * Updated start_date test * updated date format conversion in test * Updated bookmark logic for parent child streams. * Updated credentials check logic. * Updated unittest case. * Resolved PR comments and handled error for / in repository in config * added unittests for only / in config * Updated client.py to raise error for wrong org. * Added back creds check logic during object creation time. * handled the /repo and raised exception with a list * unskipped incremental child streams from assertion * Make pk of child automatic in parent stream. * updated unittests * Added logger message to print url for all streams. * updated base.py * Skipped 404 error for all streams. * Removed unnecessary __exit__ method from client * Updated doc link for each stream. * removed duplicates from extract_repos_from_config() and thrown warning message for duplicate repos * resolved PR comments and fixed pylint * Added __exit__ method in the Client object. * Added new line in the end of client.py * Updated schema for pr_commits. * resolved PR comments * Give warning message for invalid repo. * Added comments in the code. * resolved PR comments * resolved review comments * Raised error for invalid organization. * Updated logger message in client.py * Updated unittest case to use parameterized. * added a new TooManyRequests class error for 429 * resolved review comment * update variable name * resolved review comment and updated print - LOGGER * TDL 16573 sync teams at organization level (#173) * Initial commit. * Updated unittest case and resolved pylints. * Defined orgs streams in constant. * Updated extract_repo_from_config method. * Updated unit test cases. * Added back unittest cases. * TDL-19555 added missing test cases and updated test cases according to code change (#167) * added missing test cases and updated test cases according to code change * removed tags stream as it is not yet added * Updated inturrupted sync assertion * Removed bookmark conversion to utc * updated inerrupted sync assertions * resolved review comments * updated sreams in parent-child test case * resolved review comments * resolved review comments * Updated start_date test * updated date format conversion in test * unskipped incremental child streams from assertion * updated base.py * resolved review comments * resolved review comment * update variable name * resolved review comment and updated print - LOGGER * Reverted back changes of all field test case. Co-authored-by: NevilParikh14 <[email protected]> * TDL-5961 Support of custom domain (#172) * Initial commit. * Removed url from the stream class. * Updated readme and sample config. * Updated sync test to utilize custom domain config parameter `base_url`. * Updated test_stream unit test. * Removed duplicate comment. * Added support of empty string in custom domain. Co-authored-by: namrata270998 <[email protected]> * TDL-12323 Implemented currently syncing for repos and streams (#171) * TDL-12323 Implemented currently syncing for repos and streams * resolved PR review comments * TDL-19980 fixed the bug * fixed the bug when any stream not selected, but the state writes currenctly_syncing * resolved PR comments * resolved pylint * fixed cci issue * fixed cci issues * fixing cci issue * resolved cci issues * fixed cci issue * made cci happy * updated one assertion and comments * Updated verify_access_for_repo method in client. * Resolved pylint. * Updated currently syncing for teams streams. (#174) Co-authored-by: namrata270998 <[email protected]> Co-authored-by: NevilParikh14 <[email protected]> Co-authored-by: NevilParikh14 <[email protected]> Co-authored-by: namrata270998 <[email protected]> * Tdl 20302 add query param for pull requests (#175) * Added query param for pull_requests streams. * Updated unit test for pull_requests. * Updated interrupted sync test case. * Updated tap-tester for interupted sync. * TDL-19526 added missing fields (#170) * added backoff for 5xx error and fixed indexerror when only passed org in config * added missing test cases and updated test cases according to code change * removed tags stream as it is not yet added * Updated inturrupted sync assertion * Removed bookmark conversion to utc * updated inerrupted sync assertions * resolved review comments * updated sreams in parent-child test case * Initial commit. * Removed unnecessary unit test cases. * updated code comments * Resolved pylint errors. * disabled pylint for get_child_records. * Added unittest cases. * Added filter params for commits and comments stream. * Updated unit test cases. * resolved review comments * resolved review comments * Updated start_date test * updated date format conversion in test * added missing fields * Updated bookmark logic for parent child streams. * Updated credentials check logic. * Updated unittest case. * Resolved PR comments and handled error for / in repository in config * added unittests for only / in config * Updated client.py to raise error for wrong org. * Added back creds check logic during object creation time. * removed extra formatting * improved formatting * handled the /repo and raised exception with a list * unskipped incremental child streams from assertion * Make pk of child automatic in parent stream. * updated unittests * Added logger message to print url for all streams. * updated base.py * Skipped 404 error for all streams. * Removed unnecessary __exit__ method from client * Updated doc link for each stream. * removed duplicates from extract_repos_from_config() and thrown warning message for duplicate repos * resolved PR comments and fixed pylint * resolved pr comments * Added __exit__ method in the Client object. * added more fields to shared schema * removed additionalproperties as duplicate * Added new line in the end of client.py * added user to shared schema * updated indentation * Resolved PR review comments * resolved pr comments * added more references * added ref for assignees * removed description * added ref schema to reactions * fixed type of total count in reactions * removed indentation from team_members and commits * Updated schema for pr_commits. * removed _sdc_repo from users.json * removed commits from shared schema and added the original schema back * resolved PR comments * Give warning message for invalid repo. * Added comments in the code. * updated indentation * updated ref * resolved PR comments * resolved review comments * Raised error for invalid organization. * Updated logger message in client.py * Updated unittest case to use parameterized. * added missing fields * removed shared schema for some fields * added missing fields * added missing fields * reverted the type of some fields * removed extra ',' from schema * added missing fields in the KNOWN_MISSING_FIELDS for all_fields * added a new TooManyRequests class error for 429 * added missing fields in the schema * added draft in missing fields * updated indentation * updated indentation level * removed extra fields from commit->committer * added author and stats in pr_commits * added misisng field in all_fields * updated the string schema type to obj as per api doc * resolved review comment * update variable name * added string in changed object type for backup * resolved review comment and updated print - LOGGER * used shared schema for performed_via_github_app and added ref back inissue_events stream * fixed typo * TDL-14359 added properties to issue assignees (#169) * added properties to issue assignees * updated issues schema * resolved review comments * added assignees in shared schema * updated assignee to user as same schema * deleted shared assignees * reverted back to number for some schemas * removed extra',' from schema * copied the base branch fields back to assignees schema * removed additionalProperties from user.json * updated indentation level * updated indentation level * TDL 16573 sync teams at organization level (#173) * Initial commit. * Updated unittest case and resolved pylints. * Defined orgs streams in constant. * Updated extract_repo_from_config method. * Updated unit test cases. * Added back unittest cases. * TDL-19555 added missing test cases and updated test cases according to code change (#167) * added missing test cases and updated test cases according to code change * removed tags stream as it is not yet added * Updated inturrupted sync assertion * Removed bookmark conversion to utc * updated inerrupted sync assertions * resolved review comments * updated sreams in parent-child test case * resolved review comments * resolved review comments * Updated start_date test * updated date format conversion in test * unskipped incremental child streams from assertion * updated base.py * resolved review comments * resolved review comment * update variable name * resolved review comment and updated print - LOGGER * Reverted back changes of all field test case. Co-authored-by: NevilParikh14 <[email protected]> * TDL-5961 Support of custom domain (#172) * Initial commit. * Removed url from the stream class. * Updated readme and sample config. * Updated sync test to utilize custom domain config parameter `base_url`. * Updated test_stream unit test. * Removed duplicate comment. * Added support of empty string in custom domain. Co-authored-by: namrata270998 <[email protected]> * TDL-12323 Implemented currently syncing for repos and streams (#171) * TDL-12323 Implemented currently syncing for repos and streams * resolved PR review comments * TDL-19980 fixed the bug * fixed the bug when any stream not selected, but the state writes currenctly_syncing * resolved PR comments * resolved pylint * fixed cci issue * fixed cci issues * fixing cci issue * resolved cci issues * fixed cci issue * made cci happy * updated one assertion and comments * Updated verify_access_for_repo method in client. * Resolved pylint. * Updated currently syncing for teams streams. (#174) * made schema type in a single line * fixed cci issue * added date-time format for closed_at in issue_events.json Co-authored-by: NevilParikh14 <[email protected]> Co-authored-by: prijendev <[email protected]> Co-authored-by: Prijen Khokhani <[email protected]> Co-authored-by: NevilParikh14 <[email protected]> * TDL-20336 custom domain which are not created as a part of Github results into key error (#177) * Raise exception if `X-RateLimit-Reset` is not found in the header. * Updated comment in the unit test. * TDL 20339 handle empty bookmark if all repos unselected for next sync. (#178) * Handle empty bookmark if all existing repos are unselected. * Added detailed comments and unit test. * Added more comments. * Updated variable name and comments. * Updated comment. * Updated logic to return existing state. * Updated variable name and function name in unit test. * Removed duplicate field in the team_membership schema. Co-authored-by: NevilParikh14 <[email protected]> Co-authored-by: namrata270998 <[email protected]> Co-authored-by: NevilParikh14 <[email protected]> Co-authored-by: namrata270998 <[email protected]>
AJWurts
pushed a commit
to villagelabsco/tap-github
that referenced
this pull request
Oct 24, 2024
* TDL-19555 added missing test cases and updated test cases according to code change (singer-io#167) * added missing test cases and updated test cases according to code change * removed tags stream as it is not yet added * Updated inturrupted sync assertion * Removed bookmark conversion to utc * updated inerrupted sync assertions * resolved review comments * updated sreams in parent-child test case * resolved review comments * resolved review comments * Updated start_date test * updated date format conversion in test * unskipped incremental child streams from assertion * updated base.py * resolved review comments * resolved review comment * update variable name * resolved review comment and updated print - LOGGER * TDL 19530 update dict based implementation to class based (singer-io#168) * added backoff for 5xx error and fixed indexerror when only passed org in config * added missing test cases and updated test cases according to code change * removed tags stream as it is not yet added * Updated inturrupted sync assertion * Removed bookmark conversion to utc * updated inerrupted sync assertions * resolved review comments * updated sreams in parent-child test case * Initial commit. * Removed unnecessary unit test cases. * updated code comments * Resolved pylint errors. * disabled pylint for get_child_records. * Added unittest cases. * Added filter params for commits and comments stream. * Updated unit test cases. * resolved review comments * resolved review comments * Updated start_date test * updated date format conversion in test * Updated bookmark logic for parent child streams. * Updated credentials check logic. * Updated unittest case. * Resolved PR comments and handled error for / in repository in config * added unittests for only / in config * Updated client.py to raise error for wrong org. * Added back creds check logic during object creation time. * handled the /repo and raised exception with a list * unskipped incremental child streams from assertion * Make pk of child automatic in parent stream. * updated unittests * Added logger message to print url for all streams. * updated base.py * Skipped 404 error for all streams. * Removed unnecessary __exit__ method from client * Updated doc link for each stream. * removed duplicates from extract_repos_from_config() and thrown warning message for duplicate repos * resolved PR comments and fixed pylint * Added __exit__ method in the Client object. * Added new line in the end of client.py * Updated schema for pr_commits. * resolved PR comments * Give warning message for invalid repo. * Added comments in the code. * resolved PR comments * resolved review comments * Raised error for invalid organization. * Updated logger message in client.py * Updated unittest case to use parameterized. * added a new TooManyRequests class error for 429 * resolved review comment * update variable name * resolved review comment and updated print - LOGGER * TDL 16573 sync teams at organization level (singer-io#173) * Initial commit. * Updated unittest case and resolved pylints. * Defined orgs streams in constant. * Updated extract_repo_from_config method. * Updated unit test cases. * Added back unittest cases. * TDL-19555 added missing test cases and updated test cases according to code change (singer-io#167) * added missing test cases and updated test cases according to code change * removed tags stream as it is not yet added * Updated inturrupted sync assertion * Removed bookmark conversion to utc * updated inerrupted sync assertions * resolved review comments * updated sreams in parent-child test case * resolved review comments * resolved review comments * Updated start_date test * updated date format conversion in test * unskipped incremental child streams from assertion * updated base.py * resolved review comments * resolved review comment * update variable name * resolved review comment and updated print - LOGGER * Reverted back changes of all field test case. Co-authored-by: NevilParikh14 <[email protected]> * TDL-5961 Support of custom domain (singer-io#172) * Initial commit. * Removed url from the stream class. * Updated readme and sample config. * Updated sync test to utilize custom domain config parameter `base_url`. * Updated test_stream unit test. * Removed duplicate comment. * Added support of empty string in custom domain. Co-authored-by: namrata270998 <[email protected]> * TDL-12323 Implemented currently syncing for repos and streams (singer-io#171) * TDL-12323 Implemented currently syncing for repos and streams * resolved PR review comments * TDL-19980 fixed the bug * fixed the bug when any stream not selected, but the state writes currenctly_syncing * resolved PR comments * resolved pylint * fixed cci issue * fixed cci issues * fixing cci issue * resolved cci issues * fixed cci issue * made cci happy * updated one assertion and comments * Updated verify_access_for_repo method in client. * Resolved pylint. * Updated currently syncing for teams streams. (singer-io#174) Co-authored-by: namrata270998 <[email protected]> Co-authored-by: NevilParikh14 <[email protected]> Co-authored-by: NevilParikh14 <[email protected]> Co-authored-by: namrata270998 <[email protected]> * Tdl 20302 add query param for pull requests (singer-io#175) * Added query param for pull_requests streams. * Updated unit test for pull_requests. * Updated interrupted sync test case. * Updated tap-tester for interupted sync. * TDL-19526 added missing fields (singer-io#170) * added backoff for 5xx error and fixed indexerror when only passed org in config * added missing test cases and updated test cases according to code change * removed tags stream as it is not yet added * Updated inturrupted sync assertion * Removed bookmark conversion to utc * updated inerrupted sync assertions * resolved review comments * updated sreams in parent-child test case * Initial commit. * Removed unnecessary unit test cases. * updated code comments * Resolved pylint errors. * disabled pylint for get_child_records. * Added unittest cases. * Added filter params for commits and comments stream. * Updated unit test cases. * resolved review comments * resolved review comments * Updated start_date test * updated date format conversion in test * added missing fields * Updated bookmark logic for parent child streams. * Updated credentials check logic. * Updated unittest case. * Resolved PR comments and handled error for / in repository in config * added unittests for only / in config * Updated client.py to raise error for wrong org. * Added back creds check logic during object creation time. * removed extra formatting * improved formatting * handled the /repo and raised exception with a list * unskipped incremental child streams from assertion * Make pk of child automatic in parent stream. * updated unittests * Added logger message to print url for all streams. * updated base.py * Skipped 404 error for all streams. * Removed unnecessary __exit__ method from client * Updated doc link for each stream. * removed duplicates from extract_repos_from_config() and thrown warning message for duplicate repos * resolved PR comments and fixed pylint * resolved pr comments * Added __exit__ method in the Client object. * added more fields to shared schema * removed additionalproperties as duplicate * Added new line in the end of client.py * added user to shared schema * updated indentation * Resolved PR review comments * resolved pr comments * added more references * added ref for assignees * removed description * added ref schema to reactions * fixed type of total count in reactions * removed indentation from team_members and commits * Updated schema for pr_commits. * removed _sdc_repo from users.json * removed commits from shared schema and added the original schema back * resolved PR comments * Give warning message for invalid repo. * Added comments in the code. * updated indentation * updated ref * resolved PR comments * resolved review comments * Raised error for invalid organization. * Updated logger message in client.py * Updated unittest case to use parameterized. * added missing fields * removed shared schema for some fields * added missing fields * added missing fields * reverted the type of some fields * removed extra ',' from schema * added missing fields in the KNOWN_MISSING_FIELDS for all_fields * added a new TooManyRequests class error for 429 * added missing fields in the schema * added draft in missing fields * updated indentation * updated indentation level * removed extra fields from commit->committer * added author and stats in pr_commits * added misisng field in all_fields * updated the string schema type to obj as per api doc * resolved review comment * update variable name * added string in changed object type for backup * resolved review comment and updated print - LOGGER * used shared schema for performed_via_github_app and added ref back inissue_events stream * fixed typo * TDL-14359 added properties to issue assignees (singer-io#169) * added properties to issue assignees * updated issues schema * resolved review comments * added assignees in shared schema * updated assignee to user as same schema * deleted shared assignees * reverted back to number for some schemas * removed extra',' from schema * copied the base branch fields back to assignees schema * removed additionalProperties from user.json * updated indentation level * updated indentation level * TDL 16573 sync teams at organization level (singer-io#173) * Initial commit. * Updated unittest case and resolved pylints. * Defined orgs streams in constant. * Updated extract_repo_from_config method. * Updated unit test cases. * Added back unittest cases. * TDL-19555 added missing test cases and updated test cases according to code change (singer-io#167) * added missing test cases and updated test cases according to code change * removed tags stream as it is not yet added * Updated inturrupted sync assertion * Removed bookmark conversion to utc * updated inerrupted sync assertions * resolved review comments * updated sreams in parent-child test case * resolved review comments * resolved review comments * Updated start_date test * updated date format conversion in test * unskipped incremental child streams from assertion * updated base.py * resolved review comments * resolved review comment * update variable name * resolved review comment and updated print - LOGGER * Reverted back changes of all field test case. Co-authored-by: NevilParikh14 <[email protected]> * TDL-5961 Support of custom domain (singer-io#172) * Initial commit. * Removed url from the stream class. * Updated readme and sample config. * Updated sync test to utilize custom domain config parameter `base_url`. * Updated test_stream unit test. * Removed duplicate comment. * Added support of empty string in custom domain. Co-authored-by: namrata270998 <[email protected]> * TDL-12323 Implemented currently syncing for repos and streams (singer-io#171) * TDL-12323 Implemented currently syncing for repos and streams * resolved PR review comments * TDL-19980 fixed the bug * fixed the bug when any stream not selected, but the state writes currenctly_syncing * resolved PR comments * resolved pylint * fixed cci issue * fixed cci issues * fixing cci issue * resolved cci issues * fixed cci issue * made cci happy * updated one assertion and comments * Updated verify_access_for_repo method in client. * Resolved pylint. * Updated currently syncing for teams streams. (singer-io#174) * made schema type in a single line * fixed cci issue * added date-time format for closed_at in issue_events.json Co-authored-by: NevilParikh14 <[email protected]> Co-authored-by: prijendev <[email protected]> Co-authored-by: Prijen Khokhani <[email protected]> Co-authored-by: NevilParikh14 <[email protected]> * TDL-20336 custom domain which are not created as a part of Github results into key error (singer-io#177) * Raise exception if `X-RateLimit-Reset` is not found in the header. * Updated comment in the unit test. * TDL 20339 handle empty bookmark if all repos unselected for next sync. (singer-io#178) * Handle empty bookmark if all existing repos are unselected. * Added detailed comments and unit test. * Added more comments. * Updated variable name and comments. * Updated comment. * Updated logic to return existing state. * Updated variable name and function name in unit test. * Removed duplicate field in the team_membership schema. Co-authored-by: NevilParikh14 <[email protected]> Co-authored-by: namrata270998 <[email protected]> Co-authored-by: NevilParikh14 <[email protected]> Co-authored-by: namrata270998 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
pull_requestsstream.pull_requestsstream.Manual QA steps
Risks
Rollback steps