Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDL-13116: Added code change for formatting none dates #114

Merged

Conversation

hpatel41
Copy link
Contributor

@hpatel41 hpatel41 commented May 7, 2021

Description of change

TDL-13116: Formatting dates should not emit a stack-trace

Manual QA steps

  • Explicitly made "due_on"= None and checked if tap fetched that data
  • Explicitly given bookmark < "due_on" and checked if tap fetched that data
  • Explicitly given bookmark > "due_on" and checked if tap not fetched that data

Risks

Rollback steps

  • revert this branch

@hpatel41
Copy link
Contributor Author

@KAllan357,
Can you please review this PR.

@KAllan357 KAllan357 merged commit 1909ca9 into master May 25, 2021
@KAllan357 KAllan357 deleted the TDL-13116-formatting-dates-should-not-emit-stack-trace branch May 25, 2021 18:09
AJWurts pushed a commit to villagelabsco/tap-github that referenced this pull request Oct 24, 2024
* TDL-13116: Added code change for formatting none dates

* Made code changes for fetching all None dates everytime
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants