Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong html_url properties Format in projects metadata #83

Closed
asyarif93 opened this issue Jun 19, 2020 · 0 comments · Fixed by #87
Closed

Wrong html_url properties Format in projects metadata #83

asyarif93 opened this issue Jun 19, 2020 · 0 comments · Fixed by #87

Comments

@asyarif93
Copy link

Please Update/Remove format from html_url properties

tap-github/tap_github/projects.json

Lines 19 to 25 in a7d7666

"html_url": {
"type": [
"null",
"string"
],
"format": "date-time"
},

as it make parsing error when using target to postgres.
Thank you
jeffhuth-bytecode pushed a commit to jeffhuth-bytecode/tap-github that referenced this issue Jul 28, 2020
Fix issue 83: projects.json
16b99b3 
Fix [issue 83](singer-io#83) by removing `format: date-time` from `html_url` field in `projects.json`.
@jeffhuth-bytecode jeffhuth-bytecode mentioned this issue Jul 28, 2020
Merged
KAllan357 pushed a commit that referenced this issue Aug 10, 2020
@jeffhuth-bytecode
Fix issue 83, projects.json and pull_request_reviews.json (#87)
c58aff2 
* Fix issue 83: projects.json

Fix [issue 83](#83) by removing `format: date-time` from `html_url` field in `projects.json`.

* Fix pull_request_reviews.json format

Fix format: date-time from pull_request_url and href fields in pul_request_reviews.json
AJWurts pushed a commit to villagelabsco/tap-github that referenced this issue Oct 24, 2024
@jeffhuth-bytecode
Fix issue 83, projects.json and pull_request_reviews.json (singer-io#87)
8cca097 
* Fix issue 83: projects.json

Fix [issue 83](singer-io#83) by removing `format: date-time` from `html_url` field in `projects.json`.

* Fix pull_request_reviews.json format

Fix format: date-time from pull_request_url and href fields in pul_request_reviews.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue 83, projects.json and pull_request_reviews.json jeffhuth-bytecode/tap-github
1 participant
@asyarif93