Ensure no implicit @types/
includes
#912
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid the errors seen in #899 as a result of #897 this is a companion follow up to the #898 that @Emiyaaaaa made that also removes any implicitly includes
@types/
package.When no
types
is specified in thetsconfig.json
, then typescript will pull in all types in./node_modules/@types/
, no matter if those appeared there due to us including it or because it's been hoisted from one of our dependencies.Since we specify no
@types/
dependencies all such types are hoisted from our dependencies and seems to currently amount to:Most importantly this means that we have been pulling in a random
@types/node
and implicitly relied on it (seemingly by relying onxo
which relies oneslint-import-resolver-webpack
➡️webpack
➡️terser-webpack-plugin
➡️jest-worker
➡️@types/node@*
)This PR sets
"types": []
to ensure no such implicit types are included, which uncovers the issue mentioned in #899 which it solves the same way as the dom specific types were solved.Related: #908