Fix #4 Implemented auth support and with exception for mailto scheme #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The referenced issue have an unanswered question. What if a username is This pull request also needs a proper title. |
There is just not enough info in the URI to distinguish between the two different URI schemes that have a somewhat overlapping syntax. Specially in cases where the scheme doesn't require |
ruiG
changed the title
|
@ruiG Yes, that's exactly what #4 (comment) says. |
|
Closing for the above reason. See #4 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I followed the regex suggested by @kevva and I added the necessary exception for the case of a mailto uri scheme.