Remove Firefox focus reset #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for all the pull requests 🙏 |
|
I am glad I can help 😊 |
|
So good @atjn! It's actually turning in to a "modern" normalize (not to take anything away from @sindresorhus obviously) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this declaration was introduced more than 10 years ago, it was for a completely different browser than what we have now. Firefox's default implementation is now much better than this reset, as #55 also mentions. Since that issue was opened, they have also continued to improve the implementation, see fx https://bugzilla.mozilla.org/show_bug.cgi?id=1756002
I can't say for sure that there are no issues with Firefox's focus rings, but I can say for sure that these declarations are actively harmful and don't solve those theoretical issues anyway, so I definitely think they should be removed.
Closes #55