Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick start #2059

Merged
merged 21 commits into from
Aug 30, 2022
Merged

Quick start #2059

merged 21 commits into from
Aug 30, 2022

Conversation

ydarma
Copy link
Contributor

@ydarma ydarma commented Jun 11, 2022

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.
  • If it's a new feature, I have included documentation updates in both the README and the types.

Quick start guide. Fix #2016.

documentation/quickstart.md Outdated Show resolved Hide resolved
documentation/quickstart.md Outdated Show resolved Hide resolved
documentation/quickstart.md Outdated Show resolved Hide resolved
documentation/quickstart.md Outdated Show resolved Hide resolved
documentation/quickstart.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
@ydarma ydarma requested a review from sindresorhus June 13, 2022 07:16
@sindresorhus
Copy link
Owner

All my comments apply in multiple places. I did not comment on all the places, but it's implied.

@ydarma
Copy link
Contributor Author

ydarma commented Jun 13, 2022

All my comments apply in multiple places. I did not comment on all the places, but it's implied.

I understood, I tried to apply suggestions everywhere but maybe I missed something... I'll review again

@ydarma ydarma requested a review from sindresorhus June 13, 2022 15:41
@sindresorhus
Copy link
Owner

I have pushed some minor improvements: a4fed5a

@sindresorhus
Copy link
Owner

I think the text still needs improvements. There were many typos and there are probably some left too. Try to go through the text and improve it.

documentation/quickstart.md Outdated Show resolved Hide resolved
documentation/quickstart.md Outdated Show resolved Hide resolved
@ydarma
Copy link
Contributor Author

ydarma commented Jul 25, 2022

I think the text still needs improvements.

I read the text multiple times and I am afraid I am not able to improve it. I am stuck with my English. If you think about writing style, sorry I won't be able to go further. If you think about more detailed information I can try to go into details. However I think that the quick start should be kept short with pointers to the doc.

Thank for the fixes, I admit that I could have avoid some if I were more careful, but not all of them.

@sindresorhus
Copy link
Owner

You could use something like https://grammarly.com

@ydarma
Copy link
Contributor Author

ydarma commented Jul 25, 2022

Thanks, I'll try that ASAP

@ydarma ydarma requested a review from sindresorhus July 30, 2022 07:34
@ydarma ydarma requested a review from sindresorhus July 30, 2022 16:45
@sindresorhus sindresorhus requested a review from szmarczak July 30, 2022 18:03
@ydarma ydarma requested a review from szmarczak August 5, 2022 15:42
@sindresorhus sindresorhus merged commit 5c2ff68 into sindresorhus:main Aug 30, 2022
@sindresorhus
Copy link
Owner

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic documentation for 'got' object
3 participants